brett/cross-py-builder
1
0
Fork 0
mirror of https://github.com/blw1138/cross-py-builder.git synced 2026-09-07 21:41:09 -05:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix modal never dismissing and noisy 404 errors

Browse Source 
The .modal CSS display:flex override the hidden attribute, so the empty job
modal was always visible on load and closeModal() could not hide it - the
'non-dismissable empty error'. Add .modal[hidden] { display:none } so the
hidden attribute wins.

The blanket errorhandler(Exception) also converted normal HTTP 404s (e.g.
/favicon.ico, /apple-touch-icon-*.png requested by the browser) into 500s,
flooding the log. Return HTTPException instances unchanged so only genuine
500s are logged as errors.
This commit is contained in:
Brett Williams
2026-08-30 22:41:59 -05:00
parent 8a6f02b7e9
commit 5967b606c7
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ctrl/static/style.css
+1
View File
@@ -93,6 +93,7 @@ button:hover { filter: brightness(1.1); }
.badge.queued, .badge.dispatching, .badge.building { background: #1c2a40; color: var(--accent); }
.badge.cancelled { background: var(--panel-2); color: var(--muted); }
.modal[hidden] { display: none; }
.modal {
position: fixed; inset: 0;
background: rgba(0, 0, 0, 0.65);